Re: [RFC PATCH 1/1] fair.c: Add/Export find_idlest_perfer_cpu API

On Tue, 2012-08-21 at 09:07 +0200, Peter Zijlstra wrote:

On Mon, 2012-08-20 at 15:17 -0700, Shirley Ma wrote:

quoted

On Mon, 2012-08-20 at 14:00 +0200, Peter Zijlstra wrote:

quoted

On Fri, 2012-08-17 at 12:46 -0700, Shirley Ma wrote:

quoted

Add/Export a new API for per-cpu thread model networking device

driver

quoted

to choose a preferred idlest cpu within allowed cpumask.

The receiving CPUs of a networking device are not under cgroup

controls.

quoted

Normally the receiving work will be scheduled on the cpu on

which

quoted

quoted

the

quoted

interrupts are received. When such a networking device uses

per-cpu

quoted

quoted

quoted

thread model, the cpu which is chose to process the packets

might

quoted

quoted

not be

quoted

part of cgroup cpusets without using such an API here. 

On NUMA system, by using the preferred cpumask from the same

NUMA

quoted

quoted

node

quoted

would help to reduce expensive cross memory access to/from the

other

quoted

quoted

quoted

NUMA node.

KVM per-cpu vhost will be the first one to use this API. Any

other

quoted

quoted

quoted

device driver which uses per-cpu thread model and has cgroup

cpuset

quoted

quoted

quoted

control will use this API later.

How often will this be called and how do you obtain the cpumasks
provided to the function? 

It depends. It might be called pretty often if the user keeps

changing

quoted

cgroups control cpuset. It might be less called if the cgroups

control

quoted

cpuset is stable, and the host scheduler always schedules the work

on

quoted

the same NUMA node.

This just doesn't make any sense, you're scanning for the least loaded
cpu, this is unrelated to a change in cpuset. So tying the scan
frequency to changes in configuration is just broken.

Thanks for your review. I am just back from my vacation. 

Why not? the caller knows the cpuset changes, and pass the right NUMA
node to choose the idlest cpu from that NUMA node. Practically, the VMs
don't change the cgroups. So it will not frequency to change the
configuration.

quoted

The preferred cpumasks are obtained from local numa node.

So why pass it as argument at all? Also, who says the current node is
the right one? It might just be running there temporarily.

It leaves to the caller to make the right node choice. It tries to avoid
VMs running on the same cpu but on the same node with the host to
process the guest network packets.

quoted

 The allowed
cpumasks are obtained from caller's task allowed cpumasks (cgroups
control cpuset).

task->cpus_allowed != cpusets.. Also, since you're using
task->cpus_allowed, pass a task_struct *, not a cpumask. 

Based on the documentation I read before, I thought the cpus_allowed ==
cgroups control cpuset. If not, where are the cgroups control cpusets
saved?

task->cpus_allowed = tsk_cpus_allowed(task_struct *p), which is
cpumask_t.

I can change the argument from cpumask to task_struct *, and call
tsk_cpus_allowed() instead of using task->cpus_allowed.

Thanks
Shirley