Re: [PATCH] decnet: fix shutdown parameter checking
flat view
From: Steven Whitehouse <hidden>
Date: 2012-08-27 09:17:44
Also in:
lkml
On Sun, 2012-08-26 at 22:37 -0400, Xi Wang wrote:
The allowed value of "how" is SHUT_RD/SHUT_WR/SHUT_RDWR (0/1/2), rather than SHUTDOWN_MASK (3). Signed-off-by: Xi Wang <xi.wang@gmail.com>
Acked-by: Steven Whitehouse <redacted> Although it could be argued that we should also continue to accept the value 3 just in case there is any userland software out there which sends that value, Steve.
quoted hunk ↗ jump to hunk
--- net/decnet/af_decnet.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)diff --git a/net/decnet/af_decnet.c b/net/decnet/af_decnet.c index 2ba1a28..307c322 100644 --- a/net/decnet/af_decnet.c +++ b/net/decnet/af_decnet.c@@ -1313,10 +1313,10 @@ static int dn_shutdown(struct socket *sock, int how) if (scp->state == DN_O) goto out; - if (how != SHUTDOWN_MASK) + if (how != SHUT_RDWR) goto out; - sk->sk_shutdown = how; + sk->sk_shutdown = SHUTDOWN_MASK; dn_destroy_sock(sk); err = 0;