Re: [PATCH] act_mirred: do not drop packets when fails to mirror it

On 08/15/2012 11:10 PM, Jamal Hadi Salim wrote:

On Wed, 2012-08-15 at 21:42 +0800, Jason Wang wrote:

quoted

I met it actually through the following steps:

- start a kvm guest with tap and make it to be an interface of the bridge
- mirror the ingress traffic of the bridge to the tap
- terminate the qemu process, the tap device is then removed
- all packet goes to bridge would be dropped, so the network of guests
in the same bridge would be broken

Makes sense.
Can you please leave the err check braces i.e
         if (err) {
                 m->tcf_qstats.overlimits++;
                 if (m->tcfm_eaction != TCA_EGRESS_MIRROR)
                         retval = TC_ACT_SHOT;
                 else
                     retval = m->tcf_action;
         } else {
                 retval = m->tcf_action;
         }

Or at least dont use TC_ACT_STOLEN.

cheers,
jamal

Sure, will post v2. Thanks.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html