Thread (6 messages) flat view 6 messages, 2 authors, 2012-08-14

Re: [net PATCH v1 2/2] net: netprio: fd passed in SCM_RIGHTS datagram not set correctly

From: John Fastabend <hidden>
Date: 2012-08-14 03:00:43
Also in: lkml

On 8/13/2012 7:31 PM, Al Viro wrote:
On Mon, Aug 13, 2012 at 06:39:45PM -0700, John Fastabend wrote:
quoted
  		/* Bump the usage count and install the file. */
  		get_file(fp[i]);
  		fd_install(new_fd, fp[i]);
+		sock = sock_from_file(fp[i], &err);
+		if (sock)
+			sock->sk->sk_cgrp_prioidx = prioidx;
Better to do that before fd_install() exposes the sucker; it's not
a serious issue, but it's more obviously correct that way.
Right. Moved it in v2.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help