On Mon, 2012-08-06 at 11:44 +0200, Eric Dumazet wrote:

On Mon, 2012-08-06 at 17:08 +0800, Cong Wang wrote:

quoted

On Fri, 2012-08-03 at 12:10 +0200, Eric Dumazet wrote: 

quoted

I did this , just take it ;)

Do we have to pass gfp to ->ndo_netpoll_setup() too? It seems no, so far
I don't think we have to do that.

Thanks.

It is needed.

->ndo_netpoll_setup() is called from __netpoll_setup()

So it would make no sense to allow GFP_KERNEL allocations in
ndo_netpoll_setup() hgandlers if we called __netpoll_setup() with
GFP_ATOMIC gfp

I see your point. Thanks!