Thread (1 message) 1 message, 1 author, 2012-08-28

Re: [PATCH] rtlwifi: rtl8192de: remove pointless conditional before kfree_skb()

From: Larry Finger <hidden>
Date: 2012-08-28 14:44:33
Also in: linux-wireless

On 08/28/2012 08:11 AM, Wei Yongjun wrote:
From: Wei Yongjun <redacted>

Remove pointless conditional before kfree_skb().

Signed-off-by: Wei Yongjun <redacted>
---
  drivers/net/wireless/rtlwifi/rtl8192de/fw.c | 3 +--
  1 file changed, 1 insertion(+), 2 deletions(-)
Acked-by: Larry Finger <Larry.Finger.net>

Thanks,

Larry
quoted hunk
diff --git a/drivers/net/wireless/rtlwifi/rtl8192de/fw.c b/drivers/net/wireless/rtlwifi/rtl8192de/fw.c
index 895ae6c..a3aede0 100644
--- a/drivers/net/wireless/rtlwifi/rtl8192de/fw.c
+++ b/drivers/net/wireless/rtlwifi/rtl8192de/fw.c
@@ -570,8 +570,7 @@ static bool _rtl92d_cmd_send_packet(struct ieee80211_hw *hw,

  	ring = &rtlpci->tx_ring[BEACON_QUEUE];
  	pskb = __skb_dequeue(&ring->queue);
-	if (pskb)
-		kfree_skb(pskb);
+	kfree_skb(pskb);
  	spin_lock_irqsave(&rtlpriv->locks.irq_th_lock, flags);
  	pdesc = &ring->desc[idx];
  	/* discard output from call below */

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help