Re: [RFC PATCH] net: Add support for virtual machine device queues (VMDQ)

John Fastabend [off-list ref] wrote:

Or Gerlitz wrote:

quoted

John Fastabend [off-list ref] wrote:

quoted

quoted

That seems reasonable to me. Adding a 'sub' argument to the set
routines should do it. Also the 'get' routines would need to be
extended to report back these virtual net devices.

int (*ndo_set_vf_mac)(struct net_device *dev, int vf, int sub, u8* mac);
int (*ndo_set_vf_vlan)(struct net_device *dev,
                        int vf, int sub, u16 vlan, u8 qos);
int (*ndo_set_vf_tx_rate)(struct net_device *dev,
                           int vf, int sub, int rate);
int (*ndo_set_vf_spoofchk)(struct net_device *dev,
                            int vf, int sub, bool setting);
int (*ndo_get_vf_config)(struct net_device *dev,
                          int vf, int sub,
                          struct fila_vf_info *ivf)

quoted

quoted

I would need to check if any of the ixgbe/igb supported hardware can
support virtual device queues on virtual functions like this but I
presume if your looking at this you have some hardware that can.

quoted

Yes, we look on HW that can. Your suggestion makes sense,  I will check here
if this well addresses the eswitch use case we envision or/what is missing.

Sounds good let us know. Ben had some comments I need to address as well.

Thinking on this use case a little further, another concern/challenge
would actually be
**creating** these VMDQ interfaces in the guest that has the VF mapped into.

Or.