Re: [PATCH] af_unix: fix unix_nr_socks check in unix_create1()

On Aug 25, 2012, at 2:43 AM, Eric Dumazet [off-list ref] wrote:

I dont think this patch is right.

atomic_long_inc_return() is expensive, more than atomic_long_inc()

And setting a 2^63 limit for max number of files is plain wrong,
as there is no way a kernel can allocate 2^63 files structures.

(same apply on 32bit arches, but for 2^31)

If you feel you must warn a sysadmin of stupid settings, add sane
boundaries in kernel/sysctl.c, and send your patch to lkml instead.

Yeah, I agree it's better to limit max_files in sysctl.  I will send
another patch instead.  Thanks.

- xi