Re: WARNING: at net/ipv4/tcp.c:1598 tcp_recvmsg+0x641/0xd30()

On Mon, 2012-08-20 at 12:20 -0400, Dave Jones wrote:

On Fri, Aug 10, 2012 at 10:40:18PM +0200, Eric Dumazet wrote:
 
 > >  >  > backtrace:
 > >  >  > :WARNING: at net/ipv4/tcp.c:1598 tcp_recvmsg+0x641/0xd30()
 > > 
 > > We're getting more reports of this happening too.
 > 
 > Might be a driver issue with LRO / GRO/ TCP coalescing
 > 
 > So we need a _lot_ of details.

I looked over all the existing reports of this. It's a bit of a mess.
It seems to affect multiple drivers.
A big problem is that the network stack seems to get in a really screwed up state
when this happens, and the automated bug filer files these corrupted traces.

A secondary problem is that because these are automated reports, not all users
are responsive to answer questions afterwards...

Anyway, what I've gathered so far..

3.4-rc	i2400m_usb      https://bugzilla.redhat.com/show_bug.cgi?id=807114

unknown (mangled traces) https://bugzilla.redhat.com/show_bug.cgi?id=841016

possibly e1000e (also mangled) https://bugzilla.redhat.com/show_bug.cgi?id=841769

3.4.4	unknown (mangled)	https://bugzilla.redhat.com/show_bug.cgi?id=849275
 (same guy, probably e1000e)	https://bugzilla.redhat.com/show_bug.cgi?id=849276

3.5.0	r8712u  https://bugzilla.redhat.com/show_bug.cgi?id=845853

3.5.0	unknown https://bugzilla.redhat.com/show_bug.cgi?id=846991


any ideas on any additional debug printk's we could add ?

	Dave

We had a generic bug in old kernels, so you might ignore too old
reports.

This was fixed in commit 1ca7ee30630e1022dbcf1b51be20580815ffab73
(tcp: take care of overlaps in tcp_try_coalesce())