Re: [PATCH net v2] net: tcp: move sk_rx_dst_set call after tcp_create_openreq_child()

From: Eric Dumazet <redacted>
Date: Sun, 19 Aug 2012 15:41:15 +0200

On Sun, 2012-08-19 at 09:30 -0400, Neal Cardwell wrote:

quoted

This commit removes the sk_rx_dst_set calls from
tcp_create_openreq_child(), because at that point the icsk_af_ops
field of ipv6_mapped TCP sockets has not been set to its proper final
value.

Instead, to make sure we get the right sk_rx_dst_set variant
appropriate for the address family of the new connection, we have
tcp_v{4,6}_syn_recv_sock() directly call the appropriate function
shortly after the call to tcp_create_openreq_child() returns.

This also moves inet6_sk_rx_dst_set() to avoid a forward declaration
with the new approach.

Signed-off-by: Neal Cardwell <ncardwell@google.com>
Reported-by: Artem Savkov <redacted>
Cc: Eric Dumazet <edumazet@google.com>
---
 net/ipv4/tcp_ipv4.c      |    1 +
 net/ipv4/tcp_minisocks.c |    2 --
 net/ipv6/tcp_ipv6.c      |   25 +++++++++++++------------
 3 files changed, 14 insertions(+), 14 deletions(-)

Thanks Neal !

Acked-by: Eric Dumazet <edumazet@google.com>

Applied, thanks everyone.