Re: [PATCH 001/001] smsc95xx: Fix hard_header_len

On Thu, 2012-08-16 at 10:57 +0100, Steve Glendinning wrote:

Hi James,

Thanks for spotting this, I don't think I've ever tested this device with IMQ.

quoted

-       dev->net->hard_header_len += SMSC95XX_TX_OVERHEAD_CSUM;
-       dev->hard_mtu = dev->net->mtu + dev->net->hard_header_len;
+       dev->net->needed_headroom = SMSC95XX_TX_OVERHEAD_CSUM;
+       dev->hard_mtu = dev->net->mtu + dev->net->hard_header_len +
dev->net->needed_headroom;

I'm unsure what we *should* be setting hard_header_len and
needed_headroom to.  David?

hard_header_len is set to ETH_HLEN by alloc_etherdev() (in the
ether_setup() callback).  Any extra headroom you want before the
Ethernet header should indeed be specified in needed_headroom.

Ben.

-- 
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.