Thread (8 messages) flat view 8 messages, 2 authors, 2012-08-15

Re: [PATCH net 2/3] llc2: Call llc_station_exit() on llc2_init() failure path

From: Ben Hutchings <hidden>
Date: 2012-08-15 04:06:46

On Tue, 2012-08-14 at 16:52 -0700, David Miller wrote:
From: Ben Hutchings <redacted>
Date: Mon, 13 Aug 2012 13:50:43 +0100
quoted
Otherwise the station packet handler will remain registered even though
the module is unloaded.

Signed-off-by: Ben Hutchings <redacted>
This will cause section mismatch errors, you'll need to remove
the __exit tag from llc_station_exit() if you want to start
invoking it from llc2_init() which is __init.

I took care of this when applying this patch to 'net'.
Thanks, David.

llc_station.c turns out to be mostly dead code, and I have some more
radical changes to remove that which I'll send after you next merge net
into net-next.

Ben.

-- 
Ben Hutchings
I say we take off; nuke the site from orbit.  It's the only way to be sure.

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help