Thread (20 messages) 20 messages, 3 authors, 2012-08-10

[PATCH v4 00/14] some netpoll and netconsole fixes

flat view
STALE5190d SUPERSEDED

From: Cong Wang <hidden>
Date: 2012-08-10 07:10:54
Subsystem: bonding driver, documentation, ethernet bridge, netconsole, networking drivers, networking [general], team driver, the rest · Maintainers: Jay Vosburgh, Jonathan Corbet, Nikolay Aleksandrov, Ido Schimmel, Breno Leitao, Andrew Lunn, "David S. Miller", Eric Dumazet, Jakub Kicinski, Paolo Abeni, Jiri Pirko, Linus Torvalds

Status: Superseded by v5 (posted 2012-08-10). [go to v5]

Revision v4 (4 revisions archived).

Revisions (4)
  1. v2
  2. v3 [diff against previous]
  3. v4 current [diff against previous]
  4. v5 [diff against previous]
V4:
* rebase against net tree
* fix a compile error in patch 9
* update patch 7 as Stephen suggested

V3:
* add more patches
* update patch 7 as David suggested

V2:
* update patch 1/8 as Eric suggested
* drop the bridge patch, add comments instead
* add patch 8/8

This patchset fixes serval problems in netconsole and netpoll.

I ran this patch in my KVM guest with some netpoll test cases,
even covered with some corner cases, everything worked as expected.

BTW, my kernel config enables the following validatation options:

CONFIG_DEBUG_ATOMIC_SLEEP=y
CONFIG_PROVE_LOCKING=y
CONFIG_PROVE_RCU=y
CONFIG_LOCKDEP=y
CONFIG_RCU_CPU_STALL_TIMEOUT=60
CONFIG_LOCKUP_DETECTOR=y
CONFIG_HARDLOCKUP_DETECTOR=y

Cc: "David S. Miller" <davem@davemloft.net>
Signed-off-by: Cong Wang <redacted>

--------

 netpoll: use GFP_ATOMIC in slave_enable_netpoll() and
 netpoll: make __netpoll_cleanup non-block
 netconsole: do not release spin_lock when calling
 netpoll: take rcu_read_lock_bh() in netpoll_rx()
 netpoll: use netpoll_rx_on() in netpoll_rx()
 netpoll: take rcu_read_lock_bh() in
 bridge: add some comments for NETDEV_RELEASE
 bridge: use list_for_each_entry() in netpoll functions
 netpoll: check netpoll tx status on the right device
 netpoll: convert several functions to bool
 vlan: clean up vlan_dev_hard_start_xmit()
 netpoll: handle vlan tags in netpoll tx and rx path
 netpoll: re-enable irq in poll_napi()
 netconsole.txt: revision of examples for the receiver

 Documentation/networking/netconsole.txt |   19 +++++-
 drivers/net/bonding/bond_main.c         |   12 ++--
 drivers/net/netconsole.c                |    5 --
 drivers/net/team/team.c                 |   16 +++--
 include/linux/if_team.h                 |   30 ++++----
 include/linux/netdevice.h               |    3 +-
 include/linux/netpoll.h                 |   42 +++++++-----
 net/8021q/vlan_dev.c                    |   40 +++++++----
 net/bridge/br_device.c                  |   27 +++-----
 net/bridge/br_forward.c                 |    2 +-
 net/bridge/br_if.c                      |    6 ++-
 net/bridge/br_private.h                 |    4 +-
 net/core/netpoll.c                      |  109 ++++++++++++++++++++++---------
 13 files changed, 194 insertions(+), 121 deletions(-)
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help