Re: [net-next] bonding: don't allow the master to become its slave

Thu, Aug 09, 2012 at 09:39:06PM CEST, fbl@redhat.com wrote:

On Thu, 9 Aug 2012 20:03:23 +0100
Ben Hutchings [off-list ref] wrote:

quoted

On Thu, 2012-08-09 at 15:30 -0300, Flavio Leitner wrote:

quoted

It doesn't make any sense to allow the master to become
its slave. That creates a loop of events causing a crash.

What if there are other intermediate devices, e.g. the slave is a VLAN
sub-device of the bond?  And doesn't team also have this problem?

I think a more general check for such loops might be required.

Maybe patching netdev_set_master() to fail in the loop case is
the way to go.  That would work for bonding, team and bridge.

What you think?

How about other devices who do not use "->master" like vlan, macvlan?

fbl