Thread (28 messages) flat view 28 messages, 4 authors, 2012-08-08

Re: [PATCH 1/6] hash: Introduce ptr_hash_mix routine

From: David Miller <davem@davemloft.net>
Date: 2012-08-07 21:39:35

From: Pavel Emelyanov <redacted>
Date: Tue, 07 Aug 2012 13:11:41 +0400
Maybe it would be better to change the way neigh_table->hash work more
significantly then? Currently it is used like

	hash = tbl->hash(key, dev, tbl->rnd);
	hash >>= (32 - tbl->hash_shift);

i.e. the caller asks for u32 hash value and then trims some lower bits.
We do this because the hash function we use in the neigh
implementations causes the top bits to have the most entropy.

Please look at the commits that made the code this way, it's
very much intentional.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help