Thread (3 messages) flat view 3 messages, 2 authors, 2012-08-03

Re: [PATCH v2 1/1] ipv6 : ip6mr.c : Fix can't match the IPv6 multicast packets with input net device in netfilter FORWARD chain.

From: David Miller <davem@davemloft.net>
Date: 2012-08-03 06:43:15

From: Jun Zhao <redacted>
Date: Fri,  3 Aug 2012 14:27:51 +0800
quoted hunk ↗ jump to hunk
@@ -1960,7 +1962,7 @@ static int ip6mr_forward2(struct net *net, struct mr6_table *mrt,
 
 	IP6CB(skb)->flags |= IP6SKB_FORWARDED;
 
-	return NF_HOOK(NFPROTO_IPV6, NF_INET_FORWARD, skb, skb->dev, dev,
+	return NF_HOOK(NFPROTO_IPV6, NF_INET_FORWARD, skb, indev, dev,
 		       ip6mr_forward2_finish);
 
This patch has the same problem I mentioned, it means someone who is
now matching on the VIF device will now fail to do son.

You have to understand that you simply cannot change the behavior
here without breaking something for someone.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help