Re: [PATCH] ipv4: route.c cleanup

From: Eric Dumazet <redacted>
Date: Thu, 02 Aug 2012 11:23:40 +0200

On Thu, 2012-08-02 at 01:45 -0700, David Miller wrote:

quoted

From: Eric Dumazet <redacted>
Date: Thu, 02 Aug 2012 09:49:13 +0200

quoted

From: Eric Dumazet <edumazet@google.com>

Remove some unused includes and sysctls after route cache removal.

Signed-off-by: Eric Dumazet <edumazet@google.com>

I'm largely against removing the (now pointless) sysctls.

If the settings do nothing, so be it.

But it shouldn't generate warnings and errors during bootup,
which is what removing them is going to do.

Are you referring to a stale key in your /etc/sysctl.conf ?

I see no distro setting any of the route knob in their sysctl.conf file.

I'm talking about anyone, and people do set these knobs.  I've been
told by people at some large search engine that they, in fact, have
to :-)

[PATCH v2] ipv4: route.c cleanup

Remove unused includes after IP cache removal

Signed-off-by: Eric Dumazet <edumazet@google.com>

I'll apply this one, thanks.