Re: [PATCH] net: move "IPv6: sending pkt_too_big to self" to NETDEBUG
From: Joe Perches <joe@perches.com>
Date: 2012-07-28 17:29:22
Also in:
lkml
On Sat, 2012-07-28 at 17:06 +0200, Philipp Kern wrote:
ip6_xmit checks if the outgoing packet is larger than the path MTU and emits ICMPv6 packet too big locally if this is the case. Logging this, even at KERN_DEBUG, confuses users. It is also not actually helpful for debugging, given that there is no reference to the connection that triggered this event.
[]
quoted hunk ↗ jump to hunk
diff --git a/net/ipv6/ip6_output.c b/net/ipv6/ip6_output.c
[]
quoted hunk ↗ jump to hunk
@@ -241,7 +241,7 @@ int ip6_xmit(struct sock *sk, struct sk_buff *skb, struct flowi6 *fl6, dst->dev, dst_output); } - net_dbg_ratelimited("IPv6: sending pkt_too_big to self\n"); + LIMIT_NETDEBUG("IPv6: sending pkt_too_big to self\n");
LIMIT_NETDEBUG doesn't include a logging level. Add a KERN_DEBUG prefix or another KERN_<LEVEL>. Maybe it'd be better to add the context too.