Re: [PATCH] net:appletalk:ddp:fixed some codystyle issues in
flat view
From: Joe Perches <joe@perches.com>
Date: 2012-07-28 14:26:55
Also in:
lkml
On Sat, 2012-07-28 at 16:15 +0530, Jeffrin Jose wrote:
Fixed coding style issues relating to indentation found in net/appletalkddp.c."git diff -w" is empty and the compiled objects are the same too.
Hello Jeffrin. Your commit message is OK but your patch not. The switch/case that could use modification is at line 1790, not at line 685.
quoted hunk ↗ jump to hunk
diff --git a/net/appletalk/ddp.c b/net/appletalk/ddp.c
[]
quoted hunk ↗ jump to hunk
@@ -337,7 +337,7 @@ static int atif_proxy_probe_device(struct atalk_iface *atif, return -EADDRINUSE; /* Network is full... */ } - +
Adding whitespace
quoted hunk ↗ jump to hunk
struct atalk_addr *atalk_find_dev_addr(struct net_device *dev) {@@ -685,26 +685,26 @@ static int atif_ioctl(int cmd, void __user *arg) switch (cmd) { case SIOCSIFADDR: - if (!capable(CAP_NET_ADMIN)) + if (!capable(CAP_NET_ADMIN))
There's nothing wrong here to fix and you are adding incorrect indentation. Please try again and make sure you verify your proposed patches by using scripts/checkpatch.pl before submitting them.