Thread (3 messages) flat view 3 messages, 2 authors, 2012-07-20

Re: [PATCH RFT] net: Fix Neptune ethernet driver to check dma mapping error

From: Shuah Khan <hidden>
Date: 2012-07-20 21:36:41
Also in: lkml

On Fri, 2012-07-20 at 14:30 -0700, David Miller wrote:
From: Shuah Khan <redacted>
Date: Fri, 20 Jul 2012 15:27:59 -0600
quoted
Request for testing, since I don't have the hardware to test.
This is not how you post a patch.
quoted
--------------------------------------------------------------------
When you put those "---..." there, GIT is going to eliminate everything
afterwards from the commit mesage when I apply this.  Yet afterwards
is what your commit message actually is.

You therefore should do things the other way around, provide the commit
message text, then the "---..." line, then your comments you don't want
in the final commit message.
Thanks. I had it reversed in my head for some reason. Maybe not enough
coffee :) Will resend the patch now.

-- Shuah
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help