Re: resurrecting tcphealth

On Sat, 2012-07-14 at 09:56 +0200, Piotr Sawuk wrote:

On Sa, 14.07.2012, 03:31, valdis.kletnieks@vt.edu wrote:

quoted

On Fri, 13 Jul 2012 16:55:44 -0700, Stephen Hemminger said:

quoted

quoted

+			/* Course retransmit inefficiency- this packet has been received

twice. */

quoted

+			tp->dup_pkts_recv++;

I don't understand that comment, could you use a better sentence please?

I think what was intended was:

/* Curse you, retransmit inefficiency! This packet has been received at

least twice */

quoted

LOL, no. I think "course retransmit" is short for "course-grained timeout
caused retransmit" but I can't be sure since I'm not the author of these
lines. I'll replace that comment with the non-shorthand version though.
however, I think the real comment here should be:

[...]

The word you are looking for is 'coarse' not 'course' (they are
generally pronounced the same, to confuse you).

Ben.

-- 
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.