Thread (2 messages) flat view 2 messages, 2 authors, 2012-07-09

Re: [PATCH 6/7] drivers/net/ethernet/broadcom/cnic.c: remove invalid reference to list iterator variable

From: David Miller <davem@davemloft.net>
Date: 2012-07-09 22:25:09
Also in: kernel-janitors, lkml

From: Julia Lawall <redacted>
Date: Sun,  8 Jul 2012 13:37:43 +0200
From: Julia Lawall <redacted>

If list_for_each_entry, etc complete a traversal of the list, the iterator
variable ends up pointing to an address at an offset from the list head,
and not a meaningful structure.  Thus this value should not be used after
the end of the iterator.  There does not seem to be a meaningful value to
provide to netdev_warn.  Replace with pr_warn, since pr_err is used
elsewhere.

This problem was found using Coccinelle (http://coccinelle.lip6.fr/).

Signed-off-by: Julia Lawall <redacted>
Applied.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help