Thread (4 messages) 4 messages, 2 authors, 2012-08-10

Re: [PATCH] codel: refine one condition to avoid a nul rec_inv_sqrt

From: David Miller <davem@davemloft.net>
Date: 2012-07-30 21:54:13

From: Eric Dumazet <redacted>
Date: Mon, 30 Jul 2012 08:52:21 +0200
From: Eric Dumazet <edumazet@google.com>

One condition before codel_Newton_step() was not good if
we never left the dropping state for a flow. As a result
rec_inv_sqrt was 0, instead of the ~0 initial value.

codel control law was then set to a very aggressive mode, dropping
many packets before reaching 'target' and recovering from this problem.

To keep codel_vars_init() as efficient as possible, refine
the condition to make sure rec_inv_sqrt initial value is correct

Many thanks to Anton Mich for discovering the issue and suggesting
a fix.

Reported-by: Anton Mich <redacted>
Signed-off-by: Eric Dumazet <edumazet@google.com>
Applied and queued up for -stable.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help