Re: [PATCH] r8169: revert "add byte queue limit support".

On Fri, 2012-07-27 at 05:36 +0200, Stefan Lippers-Hollmann wrote:

Hi

On Tuesday 24 July 2012, Francois Romieu wrote:

quoted

Eric Dumazet [off-list ref] :

quoted

On Mon, 2012-07-23 at 22:55 +0200, Francois Romieu wrote:

quoted

This reverts commit 036dafa28da1e2565a8529de2ae663c37b7a0060.

[...]

quoted

bisection is not always the right way to qualify a problem.

I know. At some point I switch from "I could search more" to "users situation
will improve in a definite timeframe".

quoted

BQL in itself had some fixes coming _after_ commit 036dafa28da1e2565

Thanks.

They are in stable as of 3.4.5:

[…]

quoted

I have obviously not directed users at them and I do not see any
of the victims using a non -stable / -vendor or recent enough
kernel to test this patch since the issue has been reported.

They are both worth testing.

[…]

3.4.x up to and including 3.4.4 exposed the problem on these cards[1]:

r8169 0000:04:00.0: eth0: RTL8168d/8111d at 0xffffc90000c72000, 00:24:1d:72:7c:75, XID 081000c0 IRQ 44
r8169 0000:05:00.0: eth1: RTL8168d/8111d at 0xffffc90000c70000, 00:24:1d:72:7c:77, XID 081000c0 IRQ 45

while it is stable with "add byte queue limit support" reverted; 3.4.5+
was only tested with 036dafa28da1e2565a8529de2ae663c37b7a0060 reverted.

Now testing plain 3.5.0, which still includes it, has been reliable for
almost 3 days - while the issue usually triggered within one hour (3 
hours at most) in 3.4.[0-4]. It might be a little too early to give a
definitive answer, but so far r8169/ 3.5.0 looks positive.

Regards
	Stefan Lippers-Hollmann

[1]	Message-Id: [ref]
	http://lkml.kernel.org/r/[ref]

Thats real good news, thanks !