Thread (3 messages) flat view 3 messages, 3 authors, 2012-07-27

Re: [PATCH 2/3] pch_gbe: add extra clean tx

From: David Miller <davem@davemloft.net>
Date: 2012-07-26 21:31:37

From: Andy Cress <redacted>
Date: Thu, 26 Jul 2012 12:00:11 -0400
This adds extra cleaning to the pch_gbe_clean_tx routine to avoid 
transmit timeouts on some BCM PHYs that have different timing.
Also update the DRV_VERSION to 1.01, and show it.

Signed-off-by: Andy Cress <redacted>
Applied.

 ....
+		if (unused < 8) {  /* tx queue nearly full */
+			pr_debug("clean_tx: transmit queue warning (%x,%x) unused=%d\n",
+				tx_ring->next_to_clean,tx_ring->next_to_use,unused);
+		}
+	   
   ^^^^^^^^^^

Trailing whitespace.
+		for (j = 0; j < PCH_GBE_TX_WEIGHT; j++) 
                                                       ^^^

Likewise.

Clean this crap up before submitting patches formally, so I don't have
to.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help