Re: [PATCH] mlx4: Add support for EEH error recovery

On 07/25/2012 11:47 AM, Shlomo Pongartz wrote:

On 7/25/2012 1:30 AM, Or Gerlitz wrote:

quoted

On Wed, Jul 25, 2012 at 12:03 AM, David Miller [off-list ref] wrote:

quoted

Or, you promised an ACK today, I still haven't seen it.

It turned out that reacted we did, but not the ACK way.

Again, code review wise, we intended to ack it, but Shlomo has set
testing environment, under which he had some issues with the patch, as
such he preferred not to ACK it but rather bring up the issues on the
list and sort them out 1st. I thought it would be wrong to over-rule
this preference of him, and this way is fair-enough with the author
and your guide-lines, maybe I had to be more aggressive with ACKing
this, as of the merge window closing coming. So tomorrow.

Or.

quoted

There is no reason Kleber should be penalized and have his work
miss the merge window just because you guys can't be bothered
to approve this patch in a reasonable amount of time.

Therefore I'm just going to apply it later today, and don't do this
with someone's submission ever again, it impedes progress and
frustrates contributors.

.

Hi Kleber,

 

I reviewed the patch and it seems fine, here's my ACK

 

Acked-by: Shlomo Pongratz <shlomop@mellanox.com
<mailto:shlomop@mellanox.com>>

Hi Shlomo,

Thank you for reviewing my patch.

-- 
Kleber Sacilotto de Souza
IBM Linux Technology Center