[PATCH] Fix divide zero crash when xmit with no enabled port
From: ISHIKAWA Mutsumi <hidden>
Date: 2012-07-21 20:38:25
Subsystem:
networking drivers, team driver, the rest · Maintainers:
Andrew Lunn, "David S. Miller", Eric Dumazet, Jakub Kicinski, Paolo Abeni, Jiri Pirko, Linus Torvalds
hash calculation in lb_transmit() cause divide zero crash when xmit on teaming loadbalance mode with no team member port is enabled (this situation means team->en_port_count = 0). Add check team->en_port_count is not 0. --- drivers/net/team/team_mode_loadbalance.c | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/drivers/net/team/team_mode_loadbalance.c b/drivers/net/team/team_mode_loadbalance.c
index 86e8183..7b878d5 100644
--- a/drivers/net/team/team_mode_loadbalance.c
+++ b/drivers/net/team/team_mode_loadbalance.c@@ -38,6 +38,8 @@ static bool lb_transmit(struct team *team, struct sk_buff *skb) if (unlikely(!fp)) goto drop; hash = SK_RUN_FILTER(fp, skb); + if (team->en_port_count < 1) + goto drop; port_index = hash % team->en_port_count; port = team_get_port_by_index_rcu(team, port_index); if (unlikely(!port))
--
1.7.10.4