Thread (7 messages) flat view 7 messages, 4 authors, 2012-07-20

Re: [PATCH v2 net-next] tcp: fix ABC in tcp_slow_start()

From: Neal Cardwell <ncardwell@google.com>
Date: 2012-07-20 17:58:28

On Fri, Jul 20, 2012 at 8:07 AM, Yuchung Cheng [off-list ref] wrote:
On Fri, Jul 20, 2012 at 8:02 AM, Eric Dumazet [off-list ref] wrote:
quoted
From: Eric Dumazet <edumazet@google.com>

When/if sysctl_tcp_abc > 1, we expect to increase cwnd by 2 if the
received ACK acknowledges more than 2*MSS bytes, in tcp_slow_start()

Problem is this RFC 3465 statement is not correctly coded, as
the while () loop increases snd_cwnd one by one.

Add a new variable to avoid this off-by one error.

Signed-off-by: Eric Dumazet <edumazet@google.com>
Acked-by: Yuchung Cheng <redacted>
Acked-by: Neal Cardwell <ncardwell@google.com>

neal
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help