Re: [PATCH] sfc: initialize dynamic sysfs attributes for lockdep
From: Ben Hutchings <hidden>
Date: 2012-07-19 17:19:09
On Thu, 2012-07-19 at 19:04 +0200, Michal Schmidt wrote:
Dynamically allocated sysfs attributes must be initialized using sysfs_attr_init(), otherwise lockdep complains: BUG: key <address> not in .data! Signed-off-by: Michal Schmidt <redacted>
Acked-by: Ben Hutchings <redacted>
quoted hunk ↗ jump to hunk
--- drivers/net/ethernet/sfc/mcdi_mon.c | 1 + 1 file changed, 1 insertion(+)diff --git a/drivers/net/ethernet/sfc/mcdi_mon.c b/drivers/net/ethernet/sfc/mcdi_mon.c index fb7f65b..1d552f0 100644 --- a/drivers/net/ethernet/sfc/mcdi_mon.c +++ b/drivers/net/ethernet/sfc/mcdi_mon.c@@ -222,6 +222,7 @@ efx_mcdi_mon_add_attr(struct efx_nic *efx, const char *name, attr->index = index; attr->type = type; attr->limit_value = limit_value; + sysfs_attr_init(&attr->dev_attr.attr); attr->dev_attr.attr.name = attr->name; attr->dev_attr.attr.mode = S_IRUGO; attr->dev_attr.show = reader;
-- Ben Hutchings, Staff Engineer, Solarflare Not speaking for my employer; that's the marketing department's job. They asked us to note that Solarflare product names are trademarked.