Re: [PATCH net-next V1 4/4] net/mlx4_en: Add accelerated RFS support

On 7/19/2012 5:09 PM, Ben Hutchings wrote:

quoted

@@ -77,6 +77,12 @@ int mlx4_en_activate_cq(struct mlx4_en_priv *priv, struct mlx4_en_cq *cq,

quoted

 	struct mlx4_en_dev *mdev = priv->mdev;
 	int err = 0;
 	char name[25];
+	struct cpu_rmap *rmap =
+#ifdef CONFIG_RFS_ACCEL
+		priv->dev->rx_cpu_rmap;
+#else
+		NULL;
+#endif

You can write this slightly more cleanly using IS_ENABLED().

[...]

quoted

quoted

+static struct mlx4_en_filter *
+mlx4_en_filter_alloc(struct mlx4_en_priv *priv, int rxq_index, __be32 src_ip,
+                    __be32 dst_ip, __be16 src_port, __be16 dst_port,
+                    u32 flow_id)
+{

[...]

quoted

quoted

+       filter->id = priv->last_filter_id++;

[...]

You need to limit the filter IDs to be < RPS_NO_FILTER.

OK, thanks, we will send fixes for these two comments.

Or.