Re: [PATCH net-next V1 7/9] net/eipoib: Add main driver functionality
From: Ben Hutchings <hidden>
Date: 2012-07-19 16:16:19
On Thu, 2012-07-19 at 18:46 +0300, Or Gerlitz wrote:
On 7/19/2012 4:49 PM, Ben Hutchings wrote:quoted
On Wed, 2012-07-18 at 14:00 +0300, Or Gerlitz wrote:
[...]
quoted
quoted
+ .ndo_vlan_rx_add_vid = eth_ipoib_vlan_rx_add_vid, + .ndo_vlan_rx_kill_vid = eth_ipoib_vlan_rx_kill_vid,These shouldn't be needed.ok, here's the point, the eIPoIB driver maps Ethernet vlans to infiniband/IPoIB pkeys (partition keys). The underlying IPoIB devices work with these pkeys in a way which is HW accelerated, and we want the eIPoIB driver to be considered as one that support HW accelerate vlans. E.g on the TX flow we don't want that any special SW handling by the 8021q driver will be done on the skb except for setting the skb->vlan_tci field, and in the RX flow, we set skb->vlan_tci field and don't want that 8021q to try and extract it from the headers, etc. For that end, I was under the impression all the three NETIF_F_HW_VLAN_{TX,RX,FILTER) features need to be advertized. From your comment I understand now that RX/TX are enough in that respect?
[...] Yes. Ben. -- Ben Hutchings, Staff Engineer, Solarflare Not speaking for my employer; that's the marketing department's job. They asked us to note that Solarflare product names are trademarked.