Re: That's pretty much it for 3.5.0

On Tue, Jul 17, 2012 at 04:27:53PM -0700, John Fastabend wrote:

On 7/17/2012 3:18 PM, David Miller wrote:

quoted

From: John Fastabend <redacted>
Date: Tue, 17 Jul 2012 15:13:36 -0700

quoted

Perhaps the easiest way is to check net->count this should be zero
until setup_net is called.

if (!atomic_read(&init_net.count))
return ret;

Won't work, setup_net() runs via a pure_initcall().

Why not must have missed something? cgroup_init() and
cgroup_early_init() both run before _initcall() routines are
called via kernel_init() so this will stop the update in
netprio from occurring.

And I don't see any race elsewhere for this.

John, can you post the backtrace you got for this?  I replied to the patch that
you posted for this fix.  the cgroup subsystem has an early_init flag thats
supposed to prevent the initialization of cgroups that don't need initialization
until later (like via module_init() calls).
Neil

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html