Re: [PATCH] mlx4_en: map entire pages to increase throughput

From: "David Laight" <redacted>
Date: Tue, 17 Jul 2012 14:36:11 +0100

The driver will already have to cope with 'too many segments'
(I remember being passed a full sized frame made of a list
of 1-byte message blocks...)

Baring driver hardware bug workarounds, no it does not have to cope
with that.  The code is extremely simple now.

All the driver has to do is assume that a new TX packet can never
consume more than MAX_SKB_FRAGS.

Therefore it simply stops the queue if less than MAX_SKB_FRAGS
segments remain after queueing a transmit.

Your suggestion will significantly complicate driver TX paths.

If you're going to suggest a solution, it has to be completely
general enough to work in the current state of affairs, and
your idea absolutely does not.