Re: [PATCH 2/3] ipvs: add missing lock in ip_vs_ftp_init_conn()
From: Pablo Neira Ayuso <pablo@netfilter.org>
Date: 2012-07-16 21:07:57
Also in:
lvs-devel, netfilter-devel
Hi Simon, On Wed, Jul 11, 2012 at 09:19:22AM +0900, Simon Horman wrote:
From: Xiaotian Feng <redacted> We met a kernel panic in 2.6.32.43 kernel:
[...]
quoted hunk ↗ jump to hunk
net/netfilter/ipvs/ip_vs_ftp.c | 2 ++ 1 file changed, 2 insertions(+)diff --git a/net/netfilter/ipvs/ip_vs_ftp.c b/net/netfilter/ipvs/ip_vs_ftp.c index b20b29c..c2bc264 100644 --- a/net/netfilter/ipvs/ip_vs_ftp.c +++ b/net/netfilter/ipvs/ip_vs_ftp.c@@ -65,8 +65,10 @@ static int ip_vs_ftp_pasv; static int ip_vs_ftp_init_conn(struct ip_vs_app *app, struct ip_vs_conn *cp) { + spin_lock(&cp->lock); /* We use connection tracking for the command connection */ cp->flags |= IP_VS_CONN_F_NFCT; + spin_unlock(&cp->lock); return 0;
The conntrack support for FTP IPVS helper seems to be there since 2.6.37. However, the patch description mentions 2.6.32.43. Something doesn't match here, could you clarify this? Thanks.