Re: [PATCH] tc_util: fix incorrect bare number process in get_rate.
From: Stephen Hemminger <hidden>
Date: 2012-07-11 14:51:47
On Wed, 11 Jul 2012 15:24:50 +0800 Li Wei [off-list ref] wrote:
quoted hunk ↗ jump to hunk
As the comment and manpage indicated that the bare number means bytes per second, so the division is not needed. --- tc/tc_util.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)diff --git a/tc/tc_util.c b/tc/tc_util.c index 926ed08..e8d89c1 100644 --- a/tc/tc_util.c +++ b/tc/tc_util.c@@ -153,7 +153,7 @@ int get_rate(unsigned *rate, const char *str) return -1; if (*p == '\0') { - *rate = bps / 8.; /* assume bytes/sec */ + *rate = bps; /* assume bytes/sec */ return 0; }
Thanks for finding this. The documentation, code and comment do all need to be the same! But changing the code as you propose would break existing usage by scripts. Instead, the man page and comment need to change to match the reality of the existing application.