Thread (3 messages) flat view 3 messages, 2 authors, 2012-07-11

Re: [net-next:master 73/84] net/ipv4/tcp_metrics.c:252:3: error: implicit declaration of function 'inet6_twsk'

From: Fengguang Wu <hidden>
Date: 2012-07-11 09:45:16
Also in: kernel-janitors

On Wed, Jul 11, 2012 at 02:39:39AM -0700, David Miller wrote:
From: wfg@linux.intel.com
Date: Wed, 11 Jul 2012 17:12:33 +0800
quoted
net/ipv4/tcp_metrics.c: In function '__tcp_get_metrics_tw':
net/ipv4/tcp_metrics.c:252:3: error: implicit declaration of function 'inet6_twsk' [-Werror=implicit-function-declaration]
net/ipv4/tcp_metrics.c:252:7: warning: assignment makes pointer from integer without a cast [enabled by default]
net/ipv4/tcp_metrics.c:253:41: error: dereferencing pointer to incomplete type
Fixed as follows:

====================
ipv6: Move ipv6 twsk accessors outside of CONFIG_IPV6 ifdefs.

Fixes build when ipv6 is disabled.

Reported-by: Fengguang Wu <redacted>
Signed-off-by: David S. Miller <davem@davemloft.net>
---
 include/linux/ipv6.h |   32 ++++++++++++++++----------------
 1 file changed, 16 insertions(+), 16 deletions(-)
It worked, thanks!

Fengguang
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help