Re: [RFC][PATCH 1/4] skbtrace: core feature

On Wed, 2012-07-11 at 10:17 +0800, Li Yu wrote:

From: Li Yu <redacted>

This implements core feature of skbtrace, which contains glue code of
tracepoints subsystem and relay file system, and provide skbtrace API
for particular networking traces.

Thanks

Hi Li

This seems a huge amount of code, on an already complex stack.

I am not convinced its needed. It looks like a debugging aid you had to
write in order to understand better linux network stack.

Lets see if you manage to maintain this for a while before considering
upstreaming it.

You said that some 'buggy' drivers set rxhash to zero, but its a valid
operation.

You said 'it seems that RPS hashing can not work well for some corner
cases', but its a known fact.

Thanks