Re: [PATCH 06/16] tcp: Move timestamps from inetpeer to metrics cache.

On Tue, Jul 10, 2012 at 11:07 PM, David Miller [off-list ref] wrote:

+
+/* VJ's idea. Save last timestamp seen from this destination and hold
+ * it at least for normal timewait interval to use for duplicate
+ * segment detection in subsequent connections, before they enter
+ * synchronized state.
+ */
+bool tcp_remember_stamp(struct sock *sk)
+{
+       struct dst_entry *dst = __sk_dst_get(sk);
+       bool ret = false;
+
+       if (dst) {
+               struct tcp_metrics_block *tm;
+
+               rcu_read_lock();
+               tm = tcp_get_metrics(sk, dst, true);
+               if (tm) {
+                       struct tcp_sock *tp = tcp_sk(sk);
+
+                       if ((s32)(tm->tcpm_ts - tp->rx_opt.ts_recent) <= 0 ||
+                           ((u32)get_seconds() - tm->tcpm_ts_stamp > TCP_PAWS_MSL &&
+                            tm->tcpm_ts_stamp <= (u32)tp->rx_opt.ts_recent_stamp)) {
+                               tm->tcpm_ts_stamp = (u32)tp->rx_opt.ts_recent_stamp;
+                               tm->tcpm_ts = tp->rx_opt.ts_recent;
+                       }
+                       ret = true;
+               }
+               rcu_read_unlock();
+       }

A trivial thing when "git am" this patch.

ERROR: trailing whitespace
#315: FILE: net/ipv4/tcp_metrics.c:595:
+^I}^I^I$

Regards,
Lin Ming

+       return ret;
+}