Re: [net-next patch v2] bnx2x: Add run-time CNIC support

On Mon, 2012-07-09 at 14:10 -0700, David Miller wrote:

From: "Merav Sicron" <redacted>
Date: Mon, 9 Jul 2012 13:00:55 +0300

quoted

-	max_non_def_sbs = bnx2x_get_num_non_def_sbs(pdev);
+	cnic_enabled = IS_ENABLED(CONFIG_CNIC) ? 1 : 0;

This, as I said, it pointless.

Every distribution is going to turn on this Kconfig option so guarding
this at all using the Kconfig option is largely valueless.

There are still two advantages in disabling CNIC in bnx2x: Saving
resources (MSI-X vector and memory) as well as reducing some latency.
When the HW is configured to storage-offload  (rather than NIC-only
mode) it does connection search over the PCI, which is additional
0.5usec - 2.5usec, depending on the system load. When CNIC is not
enabled, the HW is configured to eliminate the search.

While it is true that distributions enable the CNIC Kconfig option, some
users that care about resources and latency compile a kernel without it.

Can you please re-consider this patch?

Thanks,
Merav