Re: [PATCH v2] bridge: netfilter: fix skb->nf_bridge NULL panic in br_nf_forward_finish

On Sat, Jul 07, 2012 at 01:27:49PM +0300, Julian Anastasov wrote:

	Hello,

On Sat, 7 Jul 2012, Lin Ming wrote:

quoted

On Sat, 2012-07-07 at 12:48 +0300, Julian Anastasov wrote:

quoted

	Very good. Thanks for tracking and fixing this bug.
Can you send a copy to Simon Horman [off-list ref]
with correct Subject. As this change can go to stable
kernels you can also improve the comments, for example:

ipvs: fix oops on NAT reply in br_nf context

	IPVS should not reset skb->nf_bridge in FORWARD hook
by calling nf_reset for NAT replies. It triggers oops in
br_nf_forward_finish.

[here follows your corrected description including
the stack trace]

How about below? Can I have your ACK?
I'll resend this patch in another mail.

	Very good. You can add my

Signed-off-by: Julian Anastasov <ja@ssi.bg>

Thanks, I will queue this up in my ipvs tree and see
about getting it included in 3.5

It seems to me that this problem has been present since 2.6.37
and thus is stable material.