Thread (6 messages) flat view 6 messages, 4 authors, 2012-07-11

Re: [PATCH] gianfar: fix potential sk_wmem_alloc imbalance

From: David Miller <davem@davemloft.net>
Date: 2012-07-09 22:28:28

From: Eric Dumazet <redacted>
Date: Thu, 05 Jul 2012 23:45:13 +0200
From: Eric Dumazet <edumazet@google.com>

commit db83d136d7f753 (gianfar: Fix missing sock reference when
processing TX time stamps) added a potential sk_wmem_alloc imbalance

If the new skb has a different truesize than old one, we can get a
negative sk_wmem_alloc once new skb is orphaned at TX completion.

Now we no longer early orphan skbs in dev_hard_start_xmit(), this
probably can lead to fatal bugs.

Signed-off-by: Eric Dumazet <edumazet@google.com>
Cc: Manfred Rudigier <redacted>
Cc: Claudiu Manoil <redacted>
Cc: Jiajun Wu <redacted>
Cc: Paul Gortmaker <redacted>
Cc: Andy Fleming <redacted>
Now that this has been tested by Paul, I've applied it.

Thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help