Re: [PATCH 1/2] netfilter: ipset: timeout fixing bug broke SET target special timeout value

On Mon, Jul 09, 2012 at 12:29:03AM -0700, David Miller wrote:

From: pablo@netfilter.org
Date: Fri,  6 Jul 2012 13:39:38 +0200

quoted

+	if (add_opt.timeout != IPSET_NO_TIMEOUT
+	    && add_opt.timeout > UINT_MAX/MSEC_PER_SEC)

We do not write conditionals like this, with operators beginning
a continued line.  Instead, write this as:

	if (a &&
	    b)

Oops, indeed, sorry. New patch attached.

I've also rebased my tree to include this change. Should I send a new
pull request?

Let me know what you prefer.