Thread (3 messages) flat view 3 messages, 3 authors, 2012-07-09

Re: [PATCH] net: dont use __netdev_alloc_skb for bounce buffer

From: David Miller <davem@davemloft.net>
Date: 2012-07-09 06:52:54

From: Eric Dumazet <redacted>
Date: Mon, 02 Jul 2012 20:36:12 +0200
From: Eric Dumazet <edumazet@google.com>

commit a1c7fff7e1 (net: netdev_alloc_skb() use build_skb()) broke b44 on
some 64bit machines.

It appears b44 and b43 use __netdev_alloc_skb() instead of alloc_skb()
for their bounce buffers.

There is no need to add an extra NET_SKB_PAD reservation for bounce
buffers :

- In TX path, NET_SKB_PAD is useless

- In RX path in b44, we force a copy of incoming frames if
  GFP_DMA allocations were needed.

Reported-and-bisected-by: Stefan Bader [off-list ref]
Signed-off-by: Eric Dumazet <edumazet@google.com>
Applied, thanks Eric.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help