Re: [PATCH net-next] cnic: Fix mmap regression.
From: "Michael Chan" <mchan@broadcom.com>
Date: 2012-07-05 22:00:21
On Fri, 2012-06-29 at 15:34 -0700, David Miller wrote:
From: "Michael Chan" <mchan@broadcom.com> Date: Fri, 29 Jun 2012 12:32:45 -0700quoted
commit 1f85d58cdf15354a7120fc9ccc9bb9c45b53af88 cnic: Remove uio mem[0]. introduced a regression as older versions of userspace app still rely on this mmap. Restore the mmap functionality and get the base address from pci_resource_start() as the nedev->base_addr has been deprecated for PCI devices. Update version to 2.5.12. Signed-off-by: Michael Chan <redacted>I really couldn't believe what you guys were doing in the original commit, but I decided to let you do stupid things and find out the hard way that removing any user visible interface is basically impossible. Applied, thanks.
David, this patch plus the earlier commit are also needed for the net tree because netdev->base_addr was removed there. Can you apply these directly to the net tree? Or you want me to send you the equivalent patches for net. Thanks.