Thread (24 messages) flat view 24 messages, 6 authors, 2012-07-05

Re: [PATCH net 1/7] qlge: Fixed packet transmit errors due to potential driver errors.

From: David Miller <davem@davemloft.net>
Date: 2012-07-03 01:41:35

From: David Miller <davem@davemloft.net>
Date: Mon, 02 Jul 2012 18:38:26 -0700 (PDT)
From: Jitendra Kalsaria <redacted>
Date: Mon, 2 Jul 2012 18:30:47 -0700
quoted
As per your comments, TX ring full is not expected behavior? All I
can think of increasing the TX queue to 1024 and clean-up in timer
instead of interrupt?
Your transmit function should never be invoked when the queue is
full, logic elsewhere in your driver should have stopped the queue
therefore preventing further invocations of your transmit function
until you wake the queue when space is liberated in the TX ring.
BTW, did it even occur to you that there is a kernel log message here
in this code path for a reason?

That log message is there because this event is unexpected and a
driver error.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help