[PATCH 00/12] Swap-over-NFS without deadlocking V6 · Mel Gorman <mgorman@suse.de> · 2012-06-20
[PATCH 05/12] mm: swap: Implement generic handler for swap_activate · Mel Gorman <mgorman@suse.de> · 2012-06-20
Re: [PATCH 05/12] mm: swap: Implement generic handler for swap_activate · Rik van Riel <hidden> · 2012-06-20
[PATCH 06/12] mm: Add get_kernel_page[s] for pinning of kernel addresses for I/O · Mel Gorman <mgorman@suse.de> · 2012-06-20
Re: [PATCH 06/12] mm: Add get_kernel_page[s] for pinning of kernel addresses for I/O · Rik van Riel <hidden> · 2012-06-20
[PATCH 12/12] Avoid dereferencing bd_disk during swap_entry_free for network storage · Mel Gorman <mgorman@suse.de> · 2012-06-20
Re: [PATCH 12/12] Avoid dereferencing bd_disk during swap_entry_free for network storage · Rik van Riel <hidden> · 2012-06-20
[PATCH 11/12] nfs: Prevent page allocator recursions with swap over NFS. · Mel Gorman <mgorman@suse.de> · 2012-06-20
Re: [PATCH 11/12] nfs: Prevent page allocator recursions with swap over NFS. · Rik van Riel <hidden> · 2012-06-20
[PATCH 10/12] nfs: enable swap on NFS · Mel Gorman <mgorman@suse.de> · 2012-06-20
Re: [PATCH 10/12] nfs: enable swap on NFS · Rik van Riel <hidden> · 2012-06-20
[PATCH 09/12] nfs: disable data cache revalidation for swapfiles · Mel Gorman <mgorman@suse.de> · 2012-06-20
Re: [PATCH 09/12] nfs: disable data cache revalidation for swapfiles · Rik van Riel <hidden> · 2012-06-20
[PATCH 08/12] nfs: teach the NFS client how to treat PG_swapcache pages · Mel Gorman <mgorman@suse.de> · 2012-06-20
Re: [PATCH 08/12] nfs: teach the NFS client how to treat PG_swapcache pages · Rik van Riel <hidden> · 2012-06-20
[PATCH 07/12] mm: Add support for direct_IO to highmem pages · Mel Gorman <mgorman@suse.de> · 2012-06-20
Re: [PATCH 07/12] mm: Add support for direct_IO to highmem pages · Rik van Riel <hidden> · 2012-06-20
[PATCH 04/12] mm: Add support for a filesystem to activate swap files and use direct_IO for writing swap pages · Mel Gorman <mgorman@suse.de> · 2012-06-20
Re: [PATCH 04/12] mm: Add support for a filesystem to activate swap files and use direct_IO for writing swap pages · Rik van Riel <hidden> · 2012-06-20
[PATCH 03/12] mm: Methods for teaching filesystems about PG_swapcache pages · Mel Gorman <mgorman@suse.de> · 2012-06-20
Re: [PATCH 03/12] mm: Methods for teaching filesystems about PG_swapcache pages · Rik van Riel <hidden> · 2012-06-20
[PATCH 02/12] selinux: tag avc cache alloc as non-critical · Mel Gorman <mgorman@suse.de> · 2012-06-20
Re: [PATCH 02/12] selinux: tag avc cache alloc as non-critical · Rik van Riel <hidden> · 2012-06-20
[PATCH 01/12] netvm: Prevent a stream-specific deadlock · Mel Gorman <mgorman@suse.de> · 2012-06-20
Re: [PATCH 01/12] netvm: Prevent a stream-specific deadlock · Mel Gorman <mgorman@suse.de> · 2012-06-20
Re: [PATCH 01/12] netvm: Prevent a stream-specific deadlock · Rik van Riel <hidden> · 2012-06-20

Re: [PATCH 12/12] Avoid dereferencing bd_disk during swap_entry_free for network storage

From: Rik van Riel <hidden>
Date: 2012-06-20 17:48:17
Also in: linux-mm, linux-nfs, lkml

On 06/20/2012 05:38 AM, Mel Gorman wrote:

Commit [b3a27d: swap: Add swap slot free callback to
block_device_operations] dereferences p->bdev->bd_disk but this is a
NULL dereference if using swap-over-NFS. This patch checks SWP_BLKDEV
on the swap_info_struct before dereferencing.

With reference to this callback, Christoph Hellwig stated "Please
just remove the callback entirely.  It has no user outside the staging
tree and was added clearly against the rules for that staging tree".
This would also be my preference but there was not an obvious way of
keeping zram in staging/ happy.

Signed-off-by: Xiaotian Feng<redacted>
Signed-off-by: Mel Gorman<mgorman@suse.de>

Acked-by: Rik van Riel<redacted>

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help