Thread (28 messages) 28 messages, 7 authors, 2012-06-12

Re: [PATCH RFC] c_can_pci: generic module for c_can on PCI

From: Alan Cox <hidden>
Date: 2012-06-04 15:53:05
Also in: linux-can, lkml

+enum c_can_pci_reg_align {
+	C_CAN_REG_ALIGN_16,
+	C_CAN_REG_ALIGN_32,
+};
Anythign wrong with 

bool aligned32;
+
+struct c_can_pci_data {
+	unsigned int reg_align;	/* Set the register alignment in the memory */
Not the enum .. indeed
+static u16 c_can_pci_read_reg_aligned_to_16bit(struct c_can_priv *priv,
+						void *reg)
I'm a bit worried this function name might be too short ;)

+	dev_info(&pdev->dev, "%s device registered (regs=%p, irq=%d)\n",
+		 KBUILD_MODNAME, priv->regs, dev->irq);
dev_dbg
+	 * do not call pci_disable_device on sta2x11 because it
+	 * break all other Bus masters on this EP
+	 */
+	if(pdev->vendor == PCI_VENDOR_ID_STMICRO &&
+	   pdev->device == PCI_DEVICE_ID_STMICRO_CAN)
+		goto out;
Is that the disabling or the dropping it into D3. We have a PCI quirk
flag for the latter. See "quirk_no_ata_d3". That will also avoid any
accidents elsewhere. Right now the quirk has "ata" in the name but the
ata is just historically because we had to quirk various disk controllers.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help