Thread (37 messages) 37 messages, 4 authors, 2012-07-03

Re: [PATCH v5] sctp: be more restrictive in transport selection on bundled sacks

From: David Miller <davem@davemloft.net>
Date: 2012-06-29 23:34:10
Also in: linux-sctp

From: Neil Horman <nhorman@tuxdriver.com>
Date: Fri, 29 Jun 2012 16:15:29 -0400
+	/* Has this transport moved the ctsn since we last sacked */
+	__u32 sack_generation;
+
 ...
+		__u32	sack_generation;
These are __u32 but they only take on the value '1' or '0'.  Please
use bool and give it a more reasonable name, a name that describes
how it is really a predicate.
-		struct sctp_association *asoc;
 		struct timer_list *timer;
-		asoc = pkt->transport->asoc;
+		struct sctp_association *asoc = pkt->transport->asoc;
+
Please leave asoc where it was, on the first line.  We encourage
listing local variables such that the longest lines come first,
then gradually shorter and short lines.
+	/*
+	 * Once we have a sack generated, check to see what our sack
+	 * generation is, if its 0, reset the transports to 0, and reset
Please format:

  /* Like
   * this.
   */

Thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help