Re: [PATCH net-next 1/4] cnic: Fix occasional NULL pointer dereference during reboot.
From: David Miller <davem@davemloft.net>
Date: 2012-06-28 04:28:54
From: "Michael Chan" <mchan@broadcom.com> Date: Wed, 27 Jun 2012 18:08:19 -0700
We register with bnx2x before we allocate ctx_tbl structure, so it is possible for bnx2x to call cnic_ctl before the structure is allocated. This can sometimes cause NULL pointer dereference of cp->ctx_tbl. We fix this by adding simple checking for valid state before proceeding. The cnic_ctl call is RCU protected so we don't have to deal with race conditions. Because of the additional checking, we need to finish the shutdown before clearing the CNIC_UP flag. Signed-off-by: Michael Chan <mchan@broadcom.com>
Applied.