Thread (3 messages) flat view 3 messages, 3 authors, 2012-06-25

Re: [PATCH net-next] net: Remove 'unlikely' qualifier in skb_steal_sock()

From: David Miller <davem@davemloft.net>
Date: 2012-06-25 23:08:55

From: Eric Dumazet <redacted>
Date: Mon, 25 Jun 2012 08:09:37 +0200
On Sun, 2012-06-24 at 16:03 -0700, Vijay Subramanian wrote:
quoted
With early demux enabled by default for TCP flows, there is high chance that
skb->sk will be non-null. 'unlikely()' was removed from __inet_lookup_skb() but
maybe it can be removed from skb_steal_sock() as well.

Note: skb_steal_sock() is also called by __inet6_lookup_skb() and
__udp4_lib_lookup_skb() but they are protected by their own 'unlikely' calls.

Signed-off-by: Vijay Subramanian <redacted>
---
Acked-by: Eric Dumazet <edumazet@google.com>
Applied, thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help